Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pruned node query #8596

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Mar 27, 2024

Fixes #8593

Depends on: lightninglabs/neutrino#297 and potentially on btcsuite/btcwallet#921 need to verify whether the neutrino package bump in lnd is sufficient.

Based on 17.4 for now.

Copy link
Contributor

coderabbitai bot commented Mar 27, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ziggie1984 ziggie1984 force-pushed the fix-pruned-node-query branch 2 times, most recently from 92979b6 to 8dff78b Compare March 27, 2024 20:11
@ziggie1984 ziggie1984 changed the base branch from master to v0-17-4-branch March 27, 2024 20:13
@saubyk saubyk added this to the v0.18.0 milestone Mar 28, 2024
@ziggie1984 ziggie1984 force-pushed the fix-pruned-node-query branch from 8dff78b to b5e799f Compare April 3, 2024 22:57
@ziggie1984 ziggie1984 force-pushed the fix-pruned-node-query branch from b5e799f to fc54cea Compare April 3, 2024 23:20
@ziggie1984 ziggie1984 marked this pull request as ready for review April 3, 2024 23:21
@ziggie1984
Copy link
Collaborator Author

ziggie1984 commented Apr 4, 2024

Close in favour of #8621

@ziggie1984 ziggie1984 closed this Apr 4, 2024
@saubyk saubyk removed this from the v0.18.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: LND 0.17.4-beta still loses sync to chain after long times of inactivity as it seems
2 participants