dbg

lightsail-network · Jul 11, 2024 · 3564414 · 3564414
1 parent 5352592
commit 3564414
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/libstellar/parser.c b/libstellar/parser.c
@@ -90,10 +90,10 @@ static bool num_bytes(size_t size, size_t *out_size) {
         *out_size = size;
         return true;
     }
-    // if (size > SIZE_MAX - 4) {
-    //     // size + 4 would overflow
-    //     return false;
-    // }
+    if (size > SIZE_MAX - 4) {
+        // size + 4 would overflow
+        return false;
+    }
     *out_size = size + 4 - remainder;
     return true;
 }
@@ -122,7 +122,6 @@ static bool parse_binary_string_ptr(buffer_t *buffer,
 
     size_t data_size = 0;
     PARSER_CHECK(num_bytes(size, &data_size))
-
     PARSER_CHECK(buffer_read_bytes(buffer, string, data_size))
     PARSER_CHECK(check_padding(*string, size, data_size))  // security check
     if (out_len) {
@@ -764,7 +763,7 @@ bool read_scval_advance(buffer_t *buffer) {
         case SCV_BYTES:
         case SCV_STRING:
         case SCV_SYMBOL: {
-            size_t data_size;
+            size_t data_size = 0;
             PARSER_CHECK(parse_uint32(buffer, &data_size))
             PARSER_CHECK(num_bytes(data_size, &data_size))
             PARSER_CHECK(buffer_advance(buffer, data_size))
@@ -1045,7 +1044,7 @@ static bool parse_invoke_host_function(buffer_t *buffer, invoke_host_function_op
             PARSER_CHECK(read_create_contract_args_advance(buffer))
             break;
         case HOST_FUNCTION_TYPE_UPLOAD_CONTRACT_WASM: {
-            size_t data_size;
+            size_t data_size = 0;
             PARSER_CHECK(parse_uint32(buffer, &data_size))
             PARSER_CHECK(num_bytes(data_size, &data_size))
             PARSER_CHECK(buffer_advance(buffer, data_size))