Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate XDR types using latest version of xdrgen #314

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Regenerate XDR types using latest version of xdrgen #314

merged 2 commits into from
Jan 9, 2021

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jan 7, 2021

The XDR classes have been regenerated using the latest version of xdrgen which provides the following two features:

stellar/xdrgen#56 Builder static inner classes to unions and structs
stellar/xdrgen#57 Constructors for typedefs

ire-and-curses
ire-and-curses approved these changes Jan 7, 2021
View reviewed changes
Copy link

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read all 149 generated files, but the first few look reasonable to me

@tamirms tamirms merged commit 6d156bd into master Jan 9, 2021
@tamirms tamirms deleted the xdrgen-upgrade branch January 9, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ire-and-curses ire-and-curses ire-and-curses approved these changes

@bartekn bartekn Awaiting requested review from bartekn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirms @ire-and-curses