Add aliases for manager services for improved autowiring support #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jan 3, 2024
Sorry, I forgot all about this ask with the way things have gone for me over the last several weeks. I'll try to throw a PR together for the docs soon. |
|
no worries. i also forgot and just noticed now. i adjusted the doc in 13be8f6 i want to cleanup rather radically for 3.x, i think no further doc refinement for the 2.x is needed now. and thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
liip_imagine.cache.manager,liip_imagine.data.manager, andliip_imagine.filter.managerservices cannot be autowired at present, requiring folks to either manually create aliases in their app's configuration or to use one of the newer dependency injection attributes to specify the right service in their classes. This PR adds the appropriate service aliases to support autowiring and remove that little bit of extra overhead needed to use these three services.