⬆️ Upgrade to Cosmos SDK v0.46.10 with ibc-go v5.2.0 #100
Conversation
| // helpers from cosmos-sdk is not helpful enough, need ibc-go helpers to backup | ||
| // (which is just the old version of "github.com/cosmos/cosmos-sdk/simapp/helpers") | ||
| // (maybe they think it is too helpful, so they modified it in the new version to be less helpful) | ||
| ibcgohelpers "github.com/cosmos/ibc-go/v5/testing/simapp/helpers" |
There was a problem hiding this comment.
What is the actual thing that is missing? GenTx?
There was a problem hiding this comment.
Yes, GenTx is missing.
BTW in a following PR #99 this import is removed since we need additional functionality for setting FeeGranter in tx
| suite.chainB = suite.coordinator.GetChain(ibctesting.GetChainID(1)) | ||
| suite.chainC = suite.coordinator.GetChain(ibctesting.GetChainID(2)) | ||
| // they changed from 0-indexed to 1-indexed, I don't understand why | ||
| // all I know is that MY CODE IS BROKEN THANKS TO THAT |
There was a problem hiding this comment.
seems to relate to this cosmos/ibc-go#774 (comment)
There was a problem hiding this comment.
It reads like "we serve big chains, you small chain fxxk off"
go.mod
Outdated
| @@ -3,92 +3,119 @@ module github.com/likecoin/likecoin-chain/v3 | |||
| go 1.18 | |||
|
|
|||
| require ( | |||
| github.com/cosmos/cosmos-sdk v0.45.11 | |||
| github.com/cosmos/ibc-go/v2 v2.4.2 | |||
| github.com/bianjieai/nft-transfer v1.1.1-beta | |||
There was a problem hiding this comment.
Please remove this in this PR
| appCodec, | ||
| keys[ibctransfertypes.StoreKey], | ||
| ibcTransferSubspace, | ||
| app.IBCKeeper.ChannelKeeper, |
There was a problem hiding this comment.
(not sure) Should we use IBCFeeKeeper here or is it a extra new optional thing?
There was a problem hiding this comment.
IBCFeeKeeper should be for incentivizing relayers? Not quite sure but I think it's not applicable here
No description provided.