💄 UI updates for Primitive NFT #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nwingt
commented
Nov 19, 2022
nwingt
commented
nwingt
requested review from
williamchong,
WeiJun0827,
AuroraHuang22 and
a team
williamchong
requested changes
Nov 21, 2022
| !this.sortedCollectedNFTs.length | ||
| !this.isCurrentTabCreated && | ||
| // NOTE: Seems computed property `this.nftClassListOfCollected` is not reflecting the actual state | ||
| !this.nftClassListMap?.collected.length |
There was a problem hiding this comment.
nftClassListOfCollected not working only in here?
Does it work if this handler is in nextTick?
There was a problem hiding this comment.
Tried, it doesn't work neither
There was a problem hiding this comment.
strange, should spend time to investigate when free
Co-authored-by: William Chong <6198816+williamchong@users.noreply.github.com>
Co-authored-by: William Chong <6198816+williamchong@users.noreply.github.com>
nwingt
commented
Nov 21, 2022
williamchong
approved these changes
Nov 21, 2022
WeiJun0827
reviewed
Nov 23, 2022
Comment on lines
-103
to
+112
| isWritingNFT() { | ||
| return isWritingNFT(this.NFTClassMetadata); | ||
| nftClassCollectionType() { | ||
| return getNFTClassCollectionType(this.NFTClassMetadata); | ||
| }, |
There was a problem hiding this comment.
Seems some conditional checks in if (this.isWritingNFT) should be refactored to if (this.nftClassCollectionType === nftClassCollectionType.WritingNFT)?
like here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.