fix: country selector change language and fetch residence list #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 20, 2023 10:22
| @@ -141,6 +143,8 @@ export const IdvDocSubmitOnSignup = ({ | |||
| is_appstore | |||
| should_hide_helper_image={shouldHideHelperImage(values?.document_type?.id)} | |||
| editable_fields={changeable_fields} | |||
| residence_list={residence_list} | |||
| warning_items={undefined} | |||
There was a problem hiding this comment.
I think its better to set the default value of warning_items as empty object rather than undefined?
likhith-deriv
merged commit b712ac9
into
likhith-deriv:likhith/KYC-274/add-missing-example-formats-for-idv-countries
1 check passed
likhith-deriv
added a commit
that referenced
this pull request
Sep 15, 2023
…-com#9349) * fix: 🐛 translation of IDV documents dropdown option * fix: 🐛 translation of default config * fix: 🐛 translation of default config * fix: 🐛 removed unused-import * fix: 🐛 refactored code * fix: ♻️ incorporated review comments * feat: ✨ added example formats for IDV docs * feat: ✨ added new text as requested by compliance * fix: ♻️ incorporated review comments * fix: country selector change language and fetch residence list (#46) * fix: country selector change language and fetch residence list * fix: residence list call for mt5 * fix: autocomplete not_found issue, loading poi page directly issue * refactor: avoid double call for fetching residence * refactor: current_language removed from deps * refactor: remove undefinied prop * fix: failing tests * fix: failing tests --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: remove commented code * fix: wrong import * refactor: ♻️ incorporated review comments * fix: failing testcase * fix: ts any rreplace * fix: resolved path issues * fix: translation issue with No results found text in dropdowns * fix: translation issue with No results found text in dropdowns * fix: Country selecror in mobile * fix: Country selecror in mobile * fix: wrong file import name --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.