refactor: 🎨 migrated account component to TSX #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ Generating Lighthouse report... |
packages/account/src/Containers/Account/__tests__/account.spec.tsx
Outdated
Show resolved
Hide resolved
packages/account/src/Containers/Account/__tests__/account.spec.tsx
Outdated
Show resolved
Hide resolved
packages/account/src/Containers/Account/page-overlay-wrapper.tsx
Outdated
Show resolved
Hide resolved
| @@ -9,7 +9,7 @@ import ProofOfOwnership from 'Sections/Verification/ProofOfOwnership'; | |||
| import TwoFactorAuthentication from 'Sections/Security/TwoFactorAuthentication'; | |||
There was a problem hiding this comment.
I am getting Parse errors in imported module 'Sections/Verification/ProofOfAddress': ';' expected. I am guessing it wants the imported and exported to be tsx?
There was a problem hiding this comment.
in the respective index file of ProofOfAdress, can you write
export { default } from ****
instead of
export default from ****
will this work?
There was a problem hiding this comment.
I think on migrating the imported files to tsx, this error should go. So I'll make those changes seperately?
shaheer-deriv
approved these changes
Aug 30, 2023
yauheni-deriv
approved these changes
Aug 30, 2023
likhith-deriv
merged commit cd01ce8
into
sprint-9/account-package-refactor
0 of 3 checks passed
likhith-deriv
added a commit
that referenced
this pull request
Sep 22, 2023
…om#9832) * refactor: ♻️ initial commit * refactor: 🎨 fixed import file paths * fix: 🧑💻 incorporate sonarcloud review * refactor: ♻️ migrated reset-trading-password component to TSX * refactor: 🎨 resolved build failure * fix: ♻️ incorporated lint errors * fix: 🎨 incorporated review comments * fix: 🐛 resize issue * refactor: 🎨 migrated account component to TSX (#47) * refactor: 🎨 migrated account component to TSX * fix: 🎨 refactored code * refactor: 🎨 migrated account to tsx * fix: 🎨 incorporated review comments * chore: 💚 trigger empty commit * fix: 🧪 failing testcase * fix: 🐛 resolve password modal API failure * fix: 🐛 bug regd disabled Financial Assessment * fix: 🚚 updated paths * Merge branch 'master' into sprint-9/account-package-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.