Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Rails API #1

Merged
merged 18 commits into from
Feb 14, 2024
Merged

Configure Rails API #1

merged 18 commits into from
Feb 14, 2024

Conversation

lily4178993
Copy link
Owner

@lily4178993 lily4178993 commented Feb 3, 2024

Description:

This PR introduces several enhancements and setup configurations to the hello-rails application. It focuses on database setup, API endpoint additions, testing improvements, linting workflow integration, CORS middleware configuration, and README updates.

Changes Made:

  • Updated database configuration to use PostgreSQL.
  • Added migration and schema for the messages table.
  • Implemented MessagesController and Message model with seed data.
  • Corrected capitalization of the greeting method in MessagesController.
  • Added an API endpoint for the greeting message.
  • Removed unused test files and the test_helper.rb.
  • Added a linters workflow for Rubocop and node_modules checker.
  • Included .rubocop.yml and updated the Gemfile with the Rubocop gem.
  • Fixed Rubocop linter errors.
  • Added the MIT License.
  • Updated README with project details and setup instructions.
  • Added the rspec-rails gem and configured spec files.
  • Added MessagesController spec for the greeting endpoint.
  • Updated the test suite setup.
  • Modified Rails environment check in rails_helper.rb.
  • Added rack-cors gem and configured CORS middleware.
  • Updated README.md with the project description and a link to the "Hello React" app.

Link to the pull request in React app

Kindly review the changes and share your feedback.

Copy link

@Omar-Muhamad Omar-Muhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔

Hi @lily4178993,

Great job, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

giphy (1)

(Highlights) Good Points: 👍

  • Your work is well documented. ✔
  • The correct workflow is used. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • N/A

[Optional] suggestions:

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

**Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@lily4178993 lily4178993 merged commit 5933aaa into development Feb 14, 2024
2 checks passed
@lily4178993 lily4178993 deleted the api/setup branch February 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants