Replace usages of cargoLock
with cargoHash
#526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating my system flake's evaluation time I noticed that removing nixos-cosmic caused a considerable speedup—through some searching I found NixOS/nixpkgs#327063, which led me to believe that the usage of
cargoLock
across the packages in this repository was the culprit.After converting all of the packages to use
cargoHash
via the script linked in NixOS/nixpkgs#357257, my evaluation time dropped by 6 seconds, as evidenced byhyperfine
:Before:
After:
I ran
nix build
on a couple of the packages to make sure nothing was obviously broken, and they built fine, but I lack the processing power to check all of them 😅Also, I am not sure if any changes would have to be made to the CI or Cachix action as a result of this, it looks like they can handle
cargoHash
though!