limayaml/defaults_test.go: use slices.Clone() to create expect variable
#2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
reviewed
Sep 3, 2024
norio-nomura
force-pushed
the
use-slices-Clone
branch
from
f20b11f to
128a1b0
Compare
…riable to avoid input variable were changed on preparing `expect` variable. Signed-off-by: Norio Nomura <norio.nomura@gmail.com> limayaml: revert fixing expect Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
The test was passing regardless of what value was assigned to `Script` because `expect.Probes[0]` and `y.Probes[0]` were the same instance. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
…ueueSize` `expect.Mounts[0]` was the same instance as each of `y.Mounts[0]` and `d.Mounts[0]`, so the test passed regardless of the value set for `Virtiofs.QueueSize`. The default for `Virtiofs.QueueSize` is `nil`, but I'll keep the code that explicitly sets it to `nil` to make it clear that `nil` is expected. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
Because `d` is no longer modified to expected values, it needs to keep `dExpect` to creating `expect` variable later. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
norio-nomura
force-pushed
the
use-slices-Clone
branch
from
128a1b0 to
621ee4c
Compare
|
Thanks! 🙏🏻 |
|
This is so much nicer like this! every change has a clear commit message explaining the change and if we need to revert a change it can be a simple revert of single commit. Regrading the actual it seems that if we need to clone so many things, we can simplify by deep copying the entire struct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid input variable were changed on preparing
expectvariable.Also fixes some tests that passed unexpectedly because input variable was changed.