do not skip udp ports in guest agent #3186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
reviewed
Feb 2, 2025
There was a problem hiding this comment.
It looks good to me, but lets see what @balajiv113 thinks.
Did you test it? can you the results?
brandonros
commented
Feb 2, 2025
| @@ -131,11 +131,6 @@ func (s *ServiceWatcher) GetPorts() []Entry { | |||
| } | |||
|
|
|||
| for _, portEntry := range service.Spec.Ports { | |||
| if portEntry.Protocol != corev1.ProtocolTCP { | |||
There was a problem hiding this comment.
add a check if grpc vs ssh is being used?
There was a problem hiding this comment.
If the guest agent knows it would be nice to skip only when using the ssh port forwarder. But it is more important to get this working first, optimizing can be done later.
|
Looks good to me. It would be great if we can try out once with a test logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3178