Checking for protected dirs must be against mountPoint and not location #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The validation code was written at a time when all mounts were mounted at `location` inside the guest because there was no separate `mountPoint` setting. Now that `mountPoint` exists, the only validation for `location` is that the path exists on the host and designates a directory. All validation to protect guest directories must be done against `mountPoint`. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
validate-mountpoint
branch
from
5d0a44f to
9de6d51
Compare
|
Sorry, just realized that I broke the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation code was written at a time when all mounts were mounted at
locationinside the guest because there was no separatemountPointsetting.Now that
mountPointexists, the only validation forlocationis that the path exists on the host and designates a directory. All validation to protect guest directories must be done againstmountPoint.Fixes #3200