Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIME fails when using molNumDensity without nMolWeights #265

Closed
gica3618 opened this issue Jun 5, 2018 · 2 comments
Closed

LIME fails when using molNumDensity without nMolWeights #265

gica3618 opened this issue Jun 5, 2018 · 2 comments

Comments

@gica3618
Copy link

gica3618 commented Jun 5, 2018

If I understand the user manual correctly, the molNumDensity function that the user can define in the model.c specifies the number densities of the radiating species directly. In other words, rather than being defined relative to the density of the colliders, with molNumDensity one can define the number densities of the radiating species in an absolute way. Therefore, defining nMolWeights should not be necessary. Still, LIME exits with "No H2 collision partner, and user didn't set par.nMolWeights." if one uses a collision partner different from H2.
As an example to reproduce the behaviour, I modified the default model.c to compute excitation of carbon by electrons, specifying the density of carbon directly using molNumDensity while at the same time not defining nMolWeights. See attached file model.txt
A similar error occurs if one uses the abundance function rather than molNumDensity, but with a collider different from H2, and without defining nMolWeights. In this situation, I would again expect that nMolWeights is not necessary, since there is only one collision partner, so its weight should be 1.
I am using LIME 1.9.1.

@allegroLeiden
Copy link
Contributor

Hi, I'll try to have a look at this next week.

allegroLeiden pushed a commit that referenced this issue Aug 3, 2018
- Code in collparts.c now tests for par->useAbun before issuing various warnings/errors about par->nMolWeights.
@allegroLeiden
Copy link
Contributor

Closed in release 1.9.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants