Faster stateq #230
Merged
Faster stateq #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2017 23:51
Moved some more non-changing computations outside the inner stateq loop. Also some general cleaning of stateq.c.
|
While I was testing this PR I noticed that with >1 threads results from different runs are not bit-level identical even if -t switch is used. This was not caused by this PR, also master branch has the same issue. I'll have a look tomorrow. |
Removed schedule(dynamic) from levelpopulations() to remove randomness caused by varying loop iteration allocations to different threads.
|
The problem was dynamic omp scheduling in levelPops(). I removed it and now the results from different runs are identical when -t switch is used. There may be a slight performance penalty, but it's probably not enough to make any difference. |
|
Thanks for this, I'll have a look at it next week. |
|
Sorry I was so long checking this. Our bloody stupid story of disk failures which started last Nov continues unabated, it's been keeping me busy. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rearrangement in stateq.c to make things faster and cleaner. Also removed some old unused code.