-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on Flutter; upgrade dependencies #90
base: master
Are you sure you want to change the base?
Conversation
In this JMAP library, Flutter is only used to execute tests. I've replaced `flutter test` with `dart test` using the dart test package: https://pub.dev/packages/test The modified code files have also been linted by the default Dart linter.
Hi @michaelstepner, thanks for your contribution. Thanks and BRs |
This reverts the formatting changes from commit a5b8e19.
@hoangdat Thanks for reviewing, I've eliminated the formatting changes in the latest commit to this PR. |
This reverts commit f81a878.
Was previously installed automatically alongside Flutter
Was previously installed automatically alongside Flutter
@dab246 the CI failures should be resolved in commit a0a16df |
Still failed. Please check log |
@dab246 would you prefer to upgrade to v3 of the Dart SDK, or downgrade to an older version of the
In a separate branch of my fork ( |
When upgrading to dio 5.0.1 or higher, had to replace: DioAdapter(dio: dio); with DioAdapter(dio: dio, matcher: const UrlRequestMatcher());
Commit 2e0c3e8 upgrades the Dart SDK to v3 and upgrades the package dependencies to their latest versions. Commit ec04a1c does so without the linter changes. I've verified that all the tests pass locally:
@dab246 you can test again in the Github Actions CI system, or let me know if you'd prefer a different approach. |
In the
jmap-dart-client
library, Flutter is only used to execute tests. This PR removes the dependency on flutter and replaces testing usingflutter test
withdart test
, using the dart test package: https://pub.dev/packages/testThe modified code files have also been linted by the default Dart linter, which has generated a large number of whitespace changes in the diff. If you'd like me to revert the whitespace changes and limit the diff to meaningful changes, just let me know.(Done!)Motivation: I'm trying to use this library in a Dart codebase that does not use Flutter, and Flutter is a heavy dependency which was causing package versioning conflicts. Upon investigation, I realized the
jmap-dart-client
package isn't using any flutter-specific features, which makes sense, since it is a backend library and flutter is an SDK for frontend UI.