Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3275 Fix FCM iOS foreground desync #3314

Merged
merged 2 commits into from
Dec 6, 2024
Merged

TF-3275 Fix FCM iOS foreground desync #3314

merged 2 commits into from
Dec 6, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Nov 28, 2024 •
edited
Loading

Issue

Root cause

  • Notification from FCM contains mutable-content: true
  • Those notification will be transfered to Notification Service Extension (See here) whether the app is in background or foreground
  • Due to the app is in foreground, no notification will be shown
  • Due to NSE handle the data, FCM on Flutter side cannot handle it

Resolved

Screen.Recording.2024-11-28.at.14.55.12.mov

@tddang-linagora tddang-linagora self-assigned this Nov 28, 2024
dab246
dab246 reviewed Dec 2, 2024
View reviewed changes
@dab246
Copy link
Member

dab246 commented Dec 2, 2024 •
edited by tddang-linagora
Loading

  • Tested on tmail.linagora.com environment. Real device iOS 18.1.1. It still doesn't work.
Screenshot 2024-12-02 at 15 07 26

IMG_9764

@tddang-linagora
Copy link
Contributor Author

It still doesn't work.

Screen.Recording.2024-12-02.at.16.11.56.mov

tmail.linagora.com worked fine

@hoangdat
Copy link
Member

hoangdat commented Dec 2, 2024

did you tested with iOS v18.* @tddang-linagora

@tddang-linagora
Copy link
Contributor Author

did you tested with iOS v18.* @tddang-linagora

I don't have a iOS 18 device. Can this be tested on simulator?

dab246
dab246 reviewed Dec 4, 2024
View reviewed changes
dab246
dab246 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • write ADR for this case

dab246
dab246 reviewed Dec 5, 2024
View reviewed changes
dab246
dab246 previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add ADR

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3275-ios-foreground-desync branch from 8714eee to cdf4b2d Compare December 5, 2024 07:37
dab246
dab246 previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangdat hoangdat merged commit de940d6 into master Dec 6, 2024
21 checks passed
@tddang-linagora tddang-linagora mentioned this pull request Jan 6, 2025
Merged
39 tasks
tddang-linagora added a commit that referenced this pull request Jan 6, 2025
@tddang-linagora
TF-3275 Fix FCM iOS foreground desync (#3314)
ed3ebe5
hoangdat pushed a commit that referenced this pull request Jan 8, 2025
@tddang-linagora @hoangdat
TF-3275 Fix FCM iOS foreground desync (#3314)
415b610
tddang-linagora added a commit that referenced this pull request Feb 5, 2025
@tddang-linagora
TF-3275 Fix FCM iOS foreground desync (#3314)
d980d74
tddang-linagora added a commit that referenced this pull request Feb 5, 2025
@tddang-linagora
TF-3275 Fix FCM iOS foreground desync (#3314)
a60d35d
hoangdat pushed a commit that referenced this pull request Feb 5, 2025
@tddang-linagora @hoangdat
TF-3275 Fix FCM iOS foreground desync (#3314)
2fcb5f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 left review comments

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tddang-linagora @dab246 @hoangdat