Allow to ignore band with FeatureExtractor #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
FeatureExtractor
analysis function requiresband_to_calc
parameter to specify passband it would pre-filter light curve on. This PR introducesband_to_calc=None
, which tells the function to ignore passband information and apply the function to the whole light curve.This option could be useful to some types of analysis, for example
light_curve.OtsuSplit
is not so sensitive to passband if it is applied to differential fluxes.Another use case is datasets where each object is observed in a single passband, for example ZTF DRs. In such cases it could be practically useful to ignore passband information.
This PR is related to #317, but covers feature extraction only.
FeatureExtractor
could should be revisited again if/when #317 is implemented.Fixes #323