Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore band with FeatureExtractor #325

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Allow to ignore band with FeatureExtractor #325

merged 1 commit into from
Dec 13, 2023

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Dec 13, 2023

Currently, FeatureExtractor analysis function requires band_to_calc parameter to specify passband it would pre-filter light curve on. This PR introduces band_to_calc=None, which tells the function to ignore passband information and apply the function to the whole light curve.

This option could be useful to some types of analysis, for example light_curve.OtsuSplit is not so sensitive to passband if it is applied to differential fluxes.

Another use case is datasets where each object is observed in a single passband, for example ZTF DRs. In such cases it could be practically useful to ignore passband information.

This PR is related to #317, but covers feature extraction only. FeatureExtractor could should be revisited again if/when #317 is implemented.

Fixes #323

@hombit hombit requested a review from dougbrn December 13, 2023 20:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4db6f6a) 94.56% compared to head (0c3e069) 94.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          24       24           
  Lines        1509     1510    +1     
=======================================
+ Hits         1427     1428    +1     
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@hombit hombit merged commit d6dde0a into main Dec 13, 2023
10 checks passed
@dougbrn dougbrn deleted the licu_all_bands branch April 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature extraction should be able to ignore passband
2 participants