Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated BaseOptions.format with explicit format types #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated BaseOptions.format with explicit format types #286

wants to merge 1 commit into from

Conversation

rscotten
Copy link

This PR changes the Typscript typings for BaseOptions.format from string to type Format = 'CODE39 | 'CODE128' | .... This will help us spell and case the formats correctly and give type-hinting from the IDE.

@rscotten
Copy link
Author

not sure why the first Travis build failed but the others passed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant