Dev #47
Merged
Dev #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked a few methods to be in line with their intended programming counterparts. Functions such as
FilterandReducewere modifying the originalSliceinstead of returning a new version. These have been reworked to create newSliceinstances. Have addedModifyto update the current pointer in place.Related Issue
Fixing up some unintended/incorrect implementations of the intended code. Added more broad unit tests. Added some additional functions to replace previous.
Changes Made
Added new code examples to the README.md file for documentation examples, added more verbose tests for existing and new methods, reworked various functions to better match common programming implementations.
How to Test
Standard Go tests.
Checklist