BlockHound: Temporarily disable detection of SecureRandom as blocking
#5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: BlockHound reported that `io.fabric8.kubernetes.client.http.StandardHttpRequest` uses a blocking call. https://github.com/line/armeria/actions/runs/7721798741/job/21048920064?pr=5370#step:17:30 ``` java.lang.Exception: java.io.FileInputStream#readBytes at com.linecorp.armeria.internal.testing.InternalTestingBlockHoundIntegration.writeBlockingMethod(InternalTestingBlockHoundIntegration.java:84) at reactor.blockhound.BlockHound$Builder.lambda$install$8(BlockHound.java:472) at reactor.blockhound.BlockHoundRuntime.checkBlocking(BlockHoundRuntime.java:89) at java.base/java.io.FileInputStream.readBytes(FileInputStream.java) at java.base/java.io.FileInputStream.read(FileInputStream.java:293) at java.base/java.io.FilterInputStream.read(FilterInputStream.java:119) at java.base/sun.security.provider.NativePRNG$RandomIO.readFully(NativePRNG.java:425) at java.base/sun.security.provider.NativePRNG$RandomIO.ensureBufferValid(NativePRNG.java:528) at java.base/sun.security.provider.NativePRNG$RandomIO.implNextBytes(NativePRNG.java:547) at java.base/sun.security.provider.NativePRNG.engineNextBytes(NativePRNG.java:221) at java.base/java.security.SecureRandom.nextBytes(SecureRandom.java:758) at java.base/java.util.UUID.randomUUID(UUID.java:151) at io.fabric8.kubernetes.client.http.StandardHttpRequest.<init>(StandardHttpRequest.java:116) at io.fabric8.kubernetes.client.http.StandardHttpRequest$Builder.build(StandardHttpRequest.java:201) ``` There is nothing we can do except add an exception rule for that. So the issue is reported to the upstream. fabric8io/kubernetes-client#5735 The blocking call is temporarily allowed until the problem is resolved in the upstream. Modifications: - Allow blocking calls inside `StandardHttpRequest$Builder.build()`. Result: Make CI build pass to identify meaningful problems.
|
Thanks for the quick review. 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BlockHound reported that
io.fabric8.kubernetes.client.http.StandardHttpRequestinvoked blocking calls.https://github.com/line/armeria/actions/runs/7721798741/job/21048920064?pr=5370#step:17:30
There is nothing we can do except add an exceptional rule for that. So the issue is reported to the upstream.
fabric8io/kubernetes-client#5735
The blocking call is temporarily allowed until the problem is resolved in the upstream.
Modifications:
StandardHttpRequest$Builder.build().Result:
Make CI build pass to identify meaningful problems.