Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ReactiveWebServerLoadBalancerInteropTest #5999

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fix flaky ReactiveWebServerLoadBalancerInteropTest #5999

merged 2 commits into from
Nov 28, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Nov 22, 2024

Motivation:

com.linecorp.armeria.spring.web.reactive.ReactiveWebServerLoadBalancerInteropTest.[1] sessionProtocol=H1C, path=/controller/api/ping
java.util.ConcurrentModificationException
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1714)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at com.linecorp.armeria.spring.web.reactive.ReactiveWebServerLoadBalancerInteropTest.assertNoErrorLogByHttpWebHandlerAdapter(ReactiveWebServerLoadBalancerInteropTest.java:148)

It seems that logAppender.list was modified while retrieving elements

Modifications:

  • Use CopyOnWriteArrayList to collect ILoggingEvent

Result:

Fixes #5462

@ikhoon
Fix flaky ReactiveWebServerLoadBalancerInteropTest
09dfc0f 
Motivation:

```
com.linecorp.armeria.spring.web.reactive.ReactiveWebServerLoadBalancerInteropTest.[1] sessionProtocol=H1C, path=/controller/api/ping
java.util.ConcurrentModificationException
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1714)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at com.linecorp.armeria.spring.web.reactive.ReactiveWebServerLoadBalancerInteropTest.assertNoErrorLogByHttpWebHandlerAdapter(ReactiveWebServerLoadBalancerInteropTest.java:148)
```

It seems that `logAppender.list` was modified while retrieving elements

Modifications:

- Use `CopyOnWriteArrayList` to collect `ILoggingEvent`

Result:

Fixes line#5462
@ikhoon ikhoon added the cleanup label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: 40a3b7d)

Job name Status Build Scan®
build-ubicloud-standard-8-jdk-8 ✅ https://ge.armeria.dev/s/vxekilo5oq37a
build-ubicloud-standard-8-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/maauyjb3etsec
build-ubicloud-standard-8-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/dqijei7d2sdgi
build-ubicloud-standard-8-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/flzkfwkujbq2w
build-ubicloud-standard-8-jdk-17-leak ✅ https://ge.armeria.dev/s/gkao3afsi7kte
build-ubicloud-standard-8-jdk-11 ✅ https://ge.armeria.dev/s/std2afxijp4qe
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/35ohlwfqyl2ji

minwoox
minwoox approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@ikhoon ikhoon merged commit 2e58501 into line:main Nov 28, 2024
14 checks passed
@ikhoon ikhoon deleted the fix-ReactiveWebServerLoadBalancerInteropTest branch November 28, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: com.linecorp.armeria.spring.web.reactive.ReactiveWebServerLoadBalancerInteropTest
3 participants
@ikhoon @jrhee17 @minwoox