Fix a bug where stale endpoints in KubernetesEndpointGroup aren't updated
#6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated Motivation: When a Kubernetes service is updated, a new Pod watcher is created and receives events. At this point, the old cache should have been cleared, but it was not cleared, so stale endpoints were exposed. Modifications: - Clear `podToNode` map when a new Pod watcher is created Result: Fixed a bug where stale endpoints remained when a Kubernetes service was updated.
jrhee17
approved these changes
Dec 3, 2024
minwoox
pushed a commit
that referenced
this pull request
Dec 3, 2024
…pdated (#6012) Motivation: When a Kubernetes service is updated, a new Pod watcher is created and receives events. The old cache should have been cleared at this point, but it was not removed, so stale endpoints were exposed. Modifications: - Clear `podToNode` map when a new Pod watcher is created Result: Fixed a bug where stale endpoints remained when a Kubernetes service was updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a Kubernetes service is updated, a new Pod watcher is created and receives events. The old cache should have been cleared at this point, but it was not removed, so stale endpoints were exposed.
Modifications:
podToNodemap when a new Pod watcher is createdResult:
Fixed a bug where stale endpoints remained when a Kubernetes service was updated.