Fix Bug Where Weight Is Set to 0 in Ramping-Up Strategy #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The remoteAddress metric can be useful for CSLB clients. However, including this metric could significantly increase the cardinality of metrics when dealing with numerous endpoints. To address this, we should offer an opt-in mechanism. Modifications: - Introduced `MeterIdPrefixFunction.builderForClient()` to enable users to manage metric tags: - Users can specify tags to include or exclude using `includeTags` and `excludeTags` in the `ClientMeterIdPrefixFunctionBuilder`. - Added debugging logs for selector and selection strategy to aid in troubleshooting. Result: - You can now optionally include the `remoteAddress` metric.
Motivation: When the original weight is less than 10, the initial weight is incorrectly set to 0, potentially leading to `EndpointSelectionTimeoutException`. Modifications: - Ensured a minimum weight of 1 is set when the original weight is greater than 1 in the ramping-up strategy. - Added debugging logs for selector and selection strategy to facilitate troubleshooting. Result: - Fix a bug where weights could unintentionally be set to 0 in ramping-up strategies.
ikhoon
approved these changes
Dec 3, 2024
jrhee17
approved these changes
Dec 3, 2024
minwoox
added a commit
that referenced
this pull request
Dec 3, 2024
Motivation: When the original weight is less than 10, the initial weight is incorrectly set to 0, potentially leading to `EndpointSelectionTimeoutException`. Modifications: - Ensured a minimum weight of 1 is set when the original weight is greater than 1 in the ramping-up strategy. - Added debugging logs for selector and selection strategy to facilitate troubleshooting. Result: - Fix a bug where weights could unintentionally be set to 0 in ramping-up strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the original weight is less than 10, the initial weight is incorrectly set to 0, potentially leading to
EndpointSelectionTimeoutException.Modifications:
Result: