Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up e2e with Playwright #1001

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Set up e2e with Playwright #1001

merged 4 commits into from
Jul 31, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Jul 29, 2024

Motivation:

E2E tests are important to verify the correctness of behavior. Mocking tests are fast and easy to inject inputs but they can't check changes in other sides.

It will not be easy to test all functions with e2e tests. So I am going to write e2e tests for core features of the webapp.

Modifications:

  • Set up Playwright for e2e tests of the webapp

@ikhoon ikhoon added this to the 0.68.0 milestone Jul 30, 2024
@ikhoon ikhoon marked this pull request as ready for review July 30, 2024 04:58
@minwoox minwoox modified the milestones: 0.68.0, 0.69.0 Jul 30, 2024
@ikhoon
Copy link
Contributor Author

ikhoon commented Jul 31, 2024

Let me merge this PR without approval since this is a basic setup for Playwright and does not change the production code. Most code was generated by npm init playwright@latest
https://playwright.dev/docs/intro#installing-playwright

@ikhoon ikhoon merged commit 42138d1 into line:main Jul 31, 2024
10 checks passed
@ikhoon ikhoon deleted the e2e-playwright branch July 31, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants