Reject invalid mirroring URI

[ikhoon]

Motivation:

An expected remote URI for mirroring is <domain.com>/<org>/<repo>.git. However, both the mirror UI and REST API didn't validate the input.

For example, a SSH URL, github.com:line/centraldogma.git is not valid in Central Dogma but can be committed. Exceptions are raised later when it is used.

Additionally, I also fixed a bug where settings tabs are not visible to admin that I found while fixing this bug.

Modifications:

• Improved the regular expression for remoteUri to strictly check the input.
• Validate a remote URI in the mirror REST API.
• Always set the project role of adminstrator to OWNER

Result:

Invalid remote URIs are now rejected by the mirror UI and API.

[minwoox]

Shouldn't we do this in the MirrorDto or MirroringServiceV1?
How about also checking if the local repo exists?

[ikhoon]

Shouldn't we do this in the MirrorDto or MirroringServiceV1?

I chose this place because the segments of remote URI in MirrorDto need to be assembled.

centraldogma/server/src/main/java/com/linecorp/centraldogma/server/internal/storage/repository/DefaultMetaRepository.java

Lines 301 to 306 in 5fec9f1

	private static MirrorConfig converterToMirrorConfig(MirrorDto mirrorDto) {
	final String remoteUri =
	mirrorDto.remoteScheme() + "://" + mirrorDto.remoteUrl() +
	MirrorUtil.normalizePath(mirrorDto.remotePath()) + '#' + mirrorDto.remoteBranch();
	return new MirrorConfig(

How about also checking if the local repo exists?

That would be covered by Mirror UI which provides a select box to list local repos.
However, validation on the server side is a also good idea. I will do it in the f/u work. 😉

[minwoox]

How about trying mirroring before pushing so that an invalid configuration isn't committed at all?
(We can probably raise an exception when the corresponding credential isn't submitted before the mirror configuration is created.)
I've implemented the k8s service in that way.

[minwoox]

👍 👍 👍

[ikhoon]

How about trying mirroring before pushing so that an invalid configuration isn't committed at all?

This PR focuses on validating a remote URI. I will do it in the next milestone while implementing #700