Remove the legacy webapp #1045
Merged
Remove the legacy webapp #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The new UI becomes stablized and we don't get addtional bug reports for them. So I think it is safe to remove the legacy webapp to improve build speed and reduce the artifact size. Modifications: - Remove `server/src/main/resource` folder - Remove build scripts for the legacy webapp in `build.gradle` - Remove `/legacy-webapp` route path from the server. Result: The legacy webapp is no longer supported.
|
If there are any concerns about deleting the legacy app, let's keep this PR open until we are ready. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
============================================
- Coverage 71.60% 71.31% -0.30%
+ Complexity 4121 4077 -44
============================================
Files 402 403 +1
Lines 16452 16359 -93
Branches 1762 1768 +6
============================================
- Hits 11781 11666 -115
- Misses 3640 3660 +20
- Partials 1031 1033 +2 ☔ View full report in Codecov by Sentry. |
minwoox
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The new UI becomes stablized and we don't get addtional bug reports for them. So I think it is safe to remove the legacy webapp to improve build speed and reduce the artifact size.
Modifications:
server/src/main/resourcefolderbuild.gradle/legacy-webapproute path from the server.Result:
The legacy webapp is no longer supported.