Move Delete Project button to Danger zone tab
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
We got two feedbacks about UX:
- `Delete Project`'s location was inappropriate.
> After I click on Project Settings, the button is immediately replaced
> with Delete Project, while I'm still hovering over it.
- Automatically focus to the project seach box on the welcome page.
> would it be possible to add something like auto-focus to the
> "Search project..." field when opening the web UI?
> Perhaps also supporting the / key would help, for consistency with
> the Projects page
Modifications:
- Create `Danger zone` tab and move `Delete Project` to it.
- Miscellaneous)
- Remove `repos` segment from all `Breadcrumb`
- I felt it was unnecessary to include `repos` since it is assumed to
be a repo without additional explanation.
- Fix to auto-focus to the search box on the welcome page.
- Fix broken APIs in the mock server.
Result:
Improved usability of the UI.
jrhee17
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We got two feedbacks about UX:
Delete Project's location was inappropriate.Automatically focus to the project seach box on the welcome page.
Modifications:
Danger zonetab and moveDelete Projectto it.repossegment from allBreadcrumbrepossince it is assumed to be a repo without additional explanation.Result:
Improved usability of the UI.