Provide a way to get notified if entries are not found when watching #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Related line#532 Currently, when we try to watch a file which doesn't exist, the watch API waits until the file is added or timeout happens. It sometimes makes user difficult to debug because the client cannot distinguish such cases. Modifications: - Add `notify-entry-not-found` preference to the watch `Prefer` header. - https://datatracker.ietf.org/doc/html/rfc7240#section-4 Result: - You can now get notified if the entry doesn't exist when watching. To-do: - Add the option to client-side
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
============================================
+ Coverage 69.88% 69.91% +0.03%
- Complexity 3281 3291 +10
============================================
Files 332 332
Lines 13036 13097 +61
Branches 1404 1416 +12
============================================
+ Hits 9110 9157 +47
- Misses 3062 3069 +7
- Partials 864 871 +7
Continue to review full report at Codecov.
|
ikhoon
approved these changes
Jun 24, 2021
|
Thanks for reviewing. 😉 |
minwoox
pushed a commit
that referenced
this pull request
Dec 9, 2021
### Motivation - #532 - To-Do of #610 ### Modifications - Put value of `notify-entry-not-found` on `Prefer` request header to get error that entries are not found on watching file/repository - Propagate error that entries are not found into `Watcher#initialValueFuture` ### Result - You can get error on watching file/repository if the entry doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Related #532
Currently, when we try to watch a file that doesn't exist,
the watch API waits until the file is added or timeout happens.
It sometimes makes user difficult to debug because the client cannot distinguish such cases.
Modifications:
notify-entry-not-foundpreference to the watchPreferheader.Result:
To-do: