Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateStatus doesn't update replication when read-only mode #656

Merged
merged 8 commits into from
Dec 23, 2021

Conversation

0x1306e6d
Copy link
Contributor

Motivation

Modification

  • Enable replication when read-only with not-replication mode and given replicating is true.
  • Disable replication when read-only with replication mode and given replicating is false.

Result

@0x1306e6d 0x1306e6d changed the title Fix updateStatus doesn't handle replicating only Fix updateStatus doesn't update replication when read-only mode Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #656 (dc9f411) into master (31223d0) will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
+ Coverage     69.90%   69.95%   +0.05%     
- Complexity     3292     3307      +15     
============================================
  Files           332      333       +1     
  Lines         13119    13135      +16     
  Branches       1424     1427       +3     
============================================
+ Hits           9171     9189      +18     
- Misses         3072     3076       +4     
+ Partials        876      870       -6     
Impacted Files Coverage Δ
...gma/server/internal/api/AdministrativeService.java 68.08% <77.77%> (-0.67%) ⬇️
...a/server/internal/api/HttpApiExceptionHandler.java 80.00% <0.00%> (-3.02%) ⬇️
...centraldogma/server/internal/thrift/Converter.java 78.94% <0.00%> (ø)
...corp/centraldogma/common/InvalidPushException.java 22.22% <0.00%> (ø)
...ntraldogma/client/armeria/ArmeriaCentralDogma.java 72.40% <0.00%> (+0.04%) ⬆️
...rnal/storage/repository/DefaultMetaRepository.java 85.38% <0.00%> (+0.11%) ⬆️
...internal/storage/repository/git/GitRepository.java 76.01% <0.00%> (+0.25%) ⬆️
...com/linecorp/centraldogma/server/CentralDogma.java 77.28% <0.00%> (+0.46%) ⬆️
...internal/storage/DirectoryBasedStorageManager.java 64.19% <0.00%> (+0.87%) ⬆️
...raldogma/server/internal/api/ContentServiceV1.java 85.82% <0.00%> (+1.20%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31223d0...dc9f411. Read the comment docs.

@minwoox minwoox added the defect label Dec 10, 2021
@minwoox minwoox added this to the 0.54.0 milestone Dec 10, 2021
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

0x1306e6d and others added 2 commits December 16, 2021 17:30
…/api/AdministrativeService.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
…/api/AdministrativeService.java

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really looks awesome. 👍
Thanks a lot!

0x1306e6d and others added 4 commits December 17, 2021 17:59
…/api/AdministrativeService.java

Co-authored-by: minux <songmw725@gmail.com>
…/api/AdministrativeService.java

Co-authored-by: minux <songmw725@gmail.com>
…/api/AdministrativeService.java

Co-authored-by: minux <songmw725@gmail.com>
@minwoox minwoox merged commit d596a34 into line:master Dec 23, 2021
@minwoox
Copy link
Contributor

minwoox commented Dec 23, 2021

Awesome! 🎉 🎉 🎉
I can't wait to see your next PR. 😆

@ikhoon ikhoon modified the milestones: 0.54.0, 0.55.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update status of writable/replicating
3 participants