-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updateStatus
doesn't update replication when read-only mode
#656
Conversation
updateStatus
doesn't handle replicating onlyupdateStatus
doesn't update replication when read-only mode
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
============================================
+ Coverage 69.90% 69.95% +0.05%
- Complexity 3292 3307 +15
============================================
Files 332 333 +1
Lines 13119 13135 +16
Branches 1424 1427 +3
============================================
+ Hits 9171 9189 +18
- Misses 3072 3076 +4
+ Partials 876 870 -6
Continue to review full report at Codecov.
|
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Show resolved
Hide resolved
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
…/api/AdministrativeService.java Co-authored-by: Ikhun Um <ih.pert@gmail.com>
…/api/AdministrativeService.java Co-authored-by: Ikhun Um <ih.pert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really looks awesome. 👍
Thanks a lot!
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Outdated
Show resolved
Hide resolved
…/api/AdministrativeService.java Co-authored-by: minux <songmw725@gmail.com>
…/api/AdministrativeService.java Co-authored-by: minux <songmw725@gmail.com>
…/api/AdministrativeService.java Co-authored-by: minux <songmw725@gmail.com>
server/src/main/java/com/linecorp/centraldogma/server/internal/api/AdministrativeService.java
Show resolved
Hide resolved
Awesome! 🎉 🎉 🎉 |
Motivation
Modification
replicating
istrue
.replicating
isfalse
.Result