Add Author as a field in Repository #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `Repository.author()` and `Repository.creationTimeMillis()` have a blocking call in it. We can add `author` and `creationTimeMillis` as member variables and assign them in the consturctor to avoid the blocking call. Modifications: - Add `author` and `creationTimeMillis` as member variables - Change `Repository.author()` and `Repository.creationTimeMillis()` methods not to have implementation Result: - `Repository.author()` and `Repository.creationTimeMillis()` do not block anymore.
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
============================================
+ Coverage 70.04% 70.15% +0.10%
+ Complexity 3415 3414 -1
============================================
Files 349 349
Lines 13482 13468 -14
Branches 1454 1454
============================================
+ Hits 9444 9448 +4
+ Misses 3153 3136 -17
+ Partials 885 884 -1
Continue to review full report at Codecov.
|
ikhoon
reviewed
Feb 24, 2022
| @@ -315,6 +318,9 @@ | |||
| commitIdDatabase.rebuild(jGitRepository); | |||
| assert headRevision.equals(commitIdDatabase.headRevision()); | |||
| } | |||
| final Commit initialCommit = blockingHistory(Revision.INIT, Revision.INIT, ALL_PATH, 1).get(0); | |||
There was a problem hiding this comment.
Could we also update CachingRepository to delegate author and creationTimeMillis?
ikhoon
approved these changes
Feb 24, 2022
|
Thanks, @ikhoon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Repository.author()andRepository.creationTimeMillis()have a blocking call in it.We can add
authorandcreationTimeMillisas member variables and assign them in the constructor to avoid the blocking call.Modifications:
authorandcreationTimeMillisas member variablesRepository.author()andRepository.creationTimeMillis()methods not to have implementationResult:
Repository.author()andRepository.creationTimeMillis()do not block anymore.