Disable Zookeeper multi address #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Zookeeper 3.6 added a new option that was ability to set mulitple addersss for quorum operations. apache/zookeeper#1048 The multiaddres was not compatible with the old protocol used in ZooKeeper 3.5.x, so the option has been disabled by apache/zookeeper#1251. In apache/zookeeper#1251, the default value of `QuorumPeer.multiAddressEnabled` was changed. https://github.com/apache/zookeeper/blob/e08cc2a782982964a57651f179a468b19e2e6010/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java#L174-L180 Since CentralDogma directly extends `QuorumPeer`, `zookeeper.multiadress` is activated automatically and Central Dogma using Zookeeper 3.5.x can't be upgraded with rolling deployment. Modifications: - Set `multiAddressEnabled` to false when creating `EmbeddedZooKeeper` Result: - Fixed an issue where CentralDogma does not perform rolling updates due to Zookeeper invalid protocol version. - Note that this bug affects 0.61.2, 0.61.3 and 0.61.4
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
============================================
+ Coverage 64.82% 64.85% +0.03%
- Complexity 3280 3283 +3
============================================
Files 356 356
Lines 13961 13962 +1
Branches 1499 1499
============================================
+ Hits 9050 9055 +5
+ Misses 4059 4058 -1
+ Partials 852 849 -3
☔ View full report in Codecov by Sentry. |
jrhee17
approved these changes
Jul 10, 2023
trustin
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Zookeeper 3.6 added a new option that was ability to set multiple adders for quorum operations. apache/zookeeper#1048 The multi address was not compatible with the old protocol used in ZooKeeper 3.5.x, so apache/zookeeper#1251 has disabled the option.
During fixing incompatibility in apache/zookeeper#1251, it omitted to change the default value of
QuorumPeer.multiAddressEnabledtofalse.https://github.com/apache/zookeeper/blob/e08cc2a782982964a57651f179a468b19e2e6010/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java#L174-L180
The default is correctly set to false when a Zookeeper server is used as a standalone mode. However, if a new
QuorumPeerinstance is manually created, it will remaintrue.Since CentralDogma directly extends
QuorumPeer,zookeeper.multiadressis activated automatically and Central Dogma using Zookeeper 3.5.x can't be upgraded with a rolling deployment.Modifications:
multiAddressEnabledto false when creatingEmbeddedZooKeeperResult: