Apply ConfigValueConverter to Mirroring configuration temporarily #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Before we support content encryption within CentralDogma, we need a way to secure the sensitive information in mirroring configuration. We can do this using `ConfigValueConverter` that is introduced via line#890 as a temporarily workaround. Modifications: - Apply `ConfigValueConverter` to mirroring configuration. Result: - You can temporarily hide sensitive information in mirroring configuration using `ConfigValueConverter`. Please note that this feature will be deprecated after we implement line#755.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
============================================
- Coverage 66.09% 66.07% -0.03%
- Complexity 3400 3403 +3
============================================
Files 363 363
Lines 14103 14117 +14
Branches 1509 1509
============================================
+ Hits 9322 9328 +6
- Misses 3917 3924 +7
- Partials 864 865 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Before we support content encryption within CentralDogma, we need a way to secure sensitive information in mirroring configuration. We can do this using
ConfigValueConverterthat is introduced via #890 as a temporary workaround.Modifications:
ConfigValueConverterto mirroring configuration.Result:
ConfigValueConverter. Please note that this feature will be deprecated after we implement Support content encryption within CentralDogma #755.