Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CentralDogma is used deployed in multiple regions/zones. Given that we will soon be supporting zone-aware load balancing from Armeria's side, we can use CentralDogma to take advantage of zone-aware load balancing.
For instance:
Modifications
XdsCentralDogmaBuilder
, which builds anArmeriaCentralDogma
based on parametersAbstractArmeriaCentralDogmaBuilder
didn't make sense for xDS, soAbstractCentralDogmaBuilder
is extended directlyArmeriaCentralDogma
from the client package to the internal package so thatXdsCentralDogmaBuilder
can also build anArmeriaCentralDogma
.CentralDogma
created byXdsCentralDogmaBuilder
creates anXdsBootstrap
internally that should be closed. For this reason,CentralDogma
now inheritsAutoCloseable
which closes underlying resources such asXdsBootstrap
orEndpointGroup
.CentralDogmaRuleDelegate
since configuring aCentralDogmaExtension
withserver#port
threw an exception since the ipv6 scope id wasn't understood.Result
java-armeria-xds
client is introduced