Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jvmTarget & ktlint config in kotlin flag preset #133

Closed
ks-yim opened this issue Oct 18, 2022 · 0 comments
Closed

Fix jvmTarget & ktlint config in kotlin flag preset #133

ks-yim opened this issue Oct 18, 2022 · 0 comments

Comments

@ks-yim
Copy link
Contributor

ks-yim commented Oct 18, 2022

Motivation:

  • Currently, compiling kotlin source with line-gradle-scripts emits the following warning if javaTargetCompatibility is >= 11. Maybe we should make this option pick up the value from javaTargetCompatibility property.
    > Task :come:module:compileKotlin
    'compileJava' task (current target is 11) and 'compileKotlin' task (current target is 1.8) jvm target compatibility should be set to the same Java version.
  • ktlint exclude("/gen-src/") filter condition doesn't work for dynamically attached source and it should be modified to...:
    filter {
        exclude { it.file.path.contains("gen-src/")
    }
  • line-gradle-scripts is currently using a old ktlint version(0.36.0) due to [ktlint 0.37.0] New indentation rule issues  pinterest/ktlint#764, but it seems the issue has been resolved in a newer linter version.
minwoox pushed a commit that referenced this issue Nov 28, 2022
Motivation:
* #133 

Modifications:
* Use `javaTargetCompatibility` property value for kotlin compile JVM target.
* Use `org.jlleitschuh.gradle.ktlint` plugin's default `ktlint` version.
* Fix `ktlint` filter exclude condition for `gen-src` so that it can properly exclude dynamically attached sources.
@ks-yim ks-yim closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant