Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase default valid_sig_block_period #348

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

egonspace
Copy link

Description

Currently, default valid_sig_block_period is 100 and this value is too small.
If we set block interval to 1 second, then after 1 minute and 40 seconds of signing, tx becomes an invalid state.
In reality, this state makes the test of vulcan fail.
We increase this up to 10000.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@cc78696). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage        ?   53.17%           
=======================================
  Files           ?      642           
  Lines           ?    67251           
  Branches        ?        0           
=======================================
  Hits            ?    35761           
  Misses          ?    28547           
  Partials        ?     2943           

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it requires human interaction (i.e. you must remain silent for xxx blocks if you are willing to delete your account), how about providing more meaningful value? (e.g. 3600 or 7200 blocks)

@egonspace
Copy link
Author

If it requires human interaction (i.e. you must remain silent for xxx blocks if you are willing to delete your account), how about providing more meaningful value? (e.g. 3600 or 7200 blocks)

I think an hour would be enough. Good advise!

@egonspace egonspace merged commit 5d8420a into Finschia:main Oct 14, 2021
@egonspace egonspace changed the title chore: increate default valid_sig_block_period chore: increase default valid_sig_block_period Oct 15, 2021
@egonspace egonspace mentioned this pull request Oct 15, 2021
9 tasks
@zemyblue zemyblue mentioned this pull request Jan 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants