Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: decrease sim test time #350

Merged
merged 9 commits into from
Oct 15, 2021
Merged

Conversation

egonspace
Copy link

@egonspace egonspace commented Oct 14, 2021

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@e5a2be9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a7f1381 differs from pull request most recent head a88a888. Consider uploading reports for the commit a88a888 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage        ?   53.17%           
=======================================
  Files           ?      642           
  Lines           ?    67248           
  Branches        ?        0           
=======================================
  Hits            ?    35760           
  Misses          ?    28545           
  Partials        ?     2943           

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about filtering the branch where the cron job runs on.

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants