fix: introduce VoterSetCounter
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a concept "voter set counter" eases integration with `ostracon`'s `VoterSet`.
egonspace
changed the title
VoterSetCounterVoterSetCounter
dudong2
reviewed
Oct 6, 2021
Now `VoteSetCounter` in HandleValidatorSignature indicates the real counted number, not a index-like number.
egonspace
reviewed
Oct 7, 2021
Check the liveness threshold only provided `VoterSetCounter > SignedBlocksWindow` meaning `VoterSetCounter >= SignedBlocksWindow + 1`.
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage ? 53.17%
=======================================
Files ? 642
Lines ? 67248
Branches ? 0
=======================================
Hits ? 35757
Misses ? 28547
Partials ? 2944 |
Log `VoterSetCounter` instead of `minVoterSetCount` which is constant.
dudong2
approved these changes
Oct 7, 2021
3 tasks
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Nov 23, 2023
5 tasks
zemyblue
added a commit
that referenced
this pull request
Dec 1, 2023
* chore: revert ostracon slashing changes (revert #347) * chore: revert block converting * chore: revert voter set comments * chore: update changelog * chore: update changelog category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a concept "voter set counter" eases integration
with
ostracon'sVoterSet.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes