fix: make proto-format bug in the Makefile
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew0722
approved these changes
Feb 16, 2022
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Mar 4, 2022
* main: fix: `make proto-format` bug in the Makefile (Finschia#438) feat: Revert sig_block_height (Finschia#434) build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (Finschia#432) build(deps): bump github.com/prometheus/client_golang (Finschia#424) chore: remove `x/wasm/linkwasmd` (Finschia#436) build(deps): bump github.com/VictoriaMetrics/fastcache (Finschia#429) fix: apply fix from release branch (Finschia#428) # Conflicts: # CHANGELOG.md
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make proto-formatbug in the Makefilemake proto-lintto use clang-format lintmake proto-formatchange the format of protobuf files as clang-format style but theproto-lintcheck golang-ci lint style. Checking and formatting are different. So need to match it.closes: #XXXX
Motivation and context
make proto-formatis not working. I think the docker image file seems to be disappeared. The cosmos-sdk also doesn't work.The right docker for formating the protobuf file is
tendermintdev/docker-build-protoHow has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(no need)