Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'user_id' in SourceGroup and SourceRoom #48

Merged
merged 4 commits into from
Jun 1, 2017
Merged

Support 'user_id' in SourceGroup and SourceRoom #48

merged 4 commits into from
Jun 1, 2017

Conversation

be-hase
Copy link
Member

@be-hase be-hase commented May 31, 2017

PR for Obtaining user consent

  • Add user_id in SourceGroup and SourceRoom
    • And deprecated sender_id because it is now confusing...

@be-hase be-hase requested a review from okdtsk May 31, 2017 13:52
@okdtsk
Copy link
Member

okdtsk commented Jun 1, 2017

How about removing abstractproperty sender_id from base Source class or some comments into its docstring because it is deprecated anymore?

@be-hase
Copy link
Member Author

be-hase commented Jun 1, 2017

I think that sender_id of concrete classes and abstract classes should be deleted at the same time.
OK, I added deprecated comments into docstring.
thanks !

okdtsk
okdtsk approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@okdtsk okdtsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :octocat:

@okdtsk okdtsk merged commit c5d9097 into master Jun 1, 2017
@be-hase be-hase deleted the support-userId-in-group-and-room branch August 7, 2017 05:09
Renari pushed a commit to Renari/line-bot-sdk-python that referenced this pull request Nov 6, 2017
@be-hase @okdtsk
Support 'user_id' in SourceGroup and SourceRoom (line#48)
9a58fb3 
* Support 'user_id' in SourceGroup and SourceRoom

* Add new line.

* Add docstring comments

* workaround (pypa/setuptools#1042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okdtsk okdtsk okdtsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@be-hase @okdtsk