Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support LINE notification messages API #326

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

linhnv
Copy link
Contributor

@linhnv linhnv commented May 24, 2024

This PR attempts to support the LINE notification messages API.

  • Send LINE notification message using phone number
  • Get number of sent LINE notification messages

@CLAassistant
Copy link

CLAassistant commented May 24, 2024

CLA assistant check
All committers have signed the CLA.

@Yang-33
Copy link
Contributor

Yang-33 commented May 24, 2024

Thank you for adding this, @linhnv !
Before starting review, let me hear if you are interested to use webhook delivery event for LINE notification message.
ref: https://developers.line.biz/en/docs/partner-docs/line-notification-messages/message-sending-complete-webhook-event/

It's optional to define the event in this change. Just I'd like to ask you use or not. Probably it's useful to receive the webhook if you use line-notification-messages.

@Yang-33 Yang-33 requested a review from mokuzon May 24, 2024 06:14
@linhnv
Copy link
Contributor Author

linhnv commented May 24, 2024

@Yang-33
I am not currently utilizing the webhook delivery event, but I believe it would be beneficial to include it.
Should I add it to this PR?

@linhnv
Copy link
Contributor Author

linhnv commented May 31, 2024

@Yang-33 @mokuzon
Apologies for any inconvenience caused! As we are preparing to release the feature that utilizes the PNP functionality, could you please provide an estimate of how long the review process for this PR will take?
This will allow us to plan for its official usage accordingly.
Thank you!

@Yang-33
Copy link
Contributor

Yang-33 commented Jun 4, 2024

I believe @mokuzon will review this, and @zenizh will release the change as v1.29.0 🙏

Copy link
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very sorry for the delay in my review.
We appreciate your contrbution.
We will begin the release process.

@mokuzon mokuzon merged commit 15d507a into line:master Jun 10, 2024
4 checks passed
@Yang-33
Copy link
Contributor

Yang-33 commented Jun 11, 2024

This change is released as v1.29.0, thank you @linhnv !
https://github.com/line/line-bot-sdk-ruby/releases/tag/v1.29.0

@linhnv
Copy link
Contributor Author

linhnv commented Jun 11, 2024

@Yang-33 @mokuzon
Thank you so much for reviewing and releasing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants