Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the embedded Redis can run on Apple silicon #53

Closed
wants to merge 5 commits into from

Conversation

akunzai
Copy link

@akunzai akunzai commented Jun 11, 2024

What is this PR for?

Overview or reasons

  • Unable to run fido2 server on Apple silicon: Error creating bean with name 'embeddedRedisServerConfig': Invocation of init method failed; nested exception is java.lang.RuntimeException: Can't start redis server. Check logs for details.

Tasks

Result

  • Run fido2 server on Apple silicon without errors

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@akunzai akunzai force-pushed the embedded-redis-on-apple-silicon branch from 6132d85 to 3c05086 Compare June 13, 2024 11:21
@akunzai akunzai force-pushed the embedded-redis-on-apple-silicon branch from 3c05086 to faba7b2 Compare June 13, 2024 11:22
@@ -107,7 +107,7 @@ dependencies {
implementation('com.auth0:java-jwt:3.4.0')

//local redis
implementation('com.github.kstyrc:embedded-redis:0.6')
implementation('com.github.codemonstur:embedded-redis:1.4.3')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes backward compatible?

Copy link
Author

@akunzai akunzai Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not, but no service relies on the Redis interface,

Due to the new embedded Redis server's dependency on libssl.so.3, the base image needed to be upgraded for backward compatibility.

@kj84park
Copy link
Member

kj84park commented Nov 1, 2024

Thank you for your help, but this issue was resolved in #56

@kj84park kj84park closed this Nov 1, 2024
@akunzai akunzai deleted the embedded-redis-on-apple-silicon branch November 1, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants