Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Update to Alertmanager v2 API #481

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Feb 15, 2024

For most things, changing v1 to v2 works.

The silence API now expects startsAt for all requests, so we make that adjustment.

The Alerts and Silences API now return directly instead of a data field so we also make that adjustment.

Also do some minor adjustments to use HTTPStatus instead of hardcoded status codes.

For most things, changing v1 to v2 works.

The silence API now expects startsAt for all requests, so we make that
adjustment.

The Alerts and Silences API now return directly instead of a data field
so we also make that adjustment.

Also do some minor adjustments to use HTTPStatus instead of hardcoded
status codes.
@kfdm kfdm requested a review from a team as a code owner February 15, 2024 01:40
@kfdm kfdm merged commit b87ed89 into line:master Feb 15, 2024
5 checks passed
@kfdm kfdm deleted the alertmanager-v2 branch February 15, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants