Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First cut at request_update #1128

Merged
merged 7 commits into from
Aug 20, 2020
Merged

First cut at request_update #1128

merged 7 commits into from
Aug 20, 2020

Commits on Aug 13, 2020

  1. First cut at request_update 

    Fixes #1073. This version is largely for discussion, as it hasn't been
tested at all.
    @raphlinus
    raphlinus committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    8b78405 View commit details
    Browse the repository at this point in the history

  2. Clear up parent/child context confusion

    @raphlinus
    raphlinus committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    2ca7dca View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Clean up patch 

    Remove the `request_update_child` variant, as it likely won't be used.
Add changelog.
    @raphlinus
    raphlinus committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6c88295 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into request_update

    @raphlinus
    raphlinus committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7c57604 View commit details
    Browse the repository at this point in the history

  3. Fix commit number 

    I forgot a commit number was already assigned, as this was in draft.

Also remove generic parameters, as per review.
    @raphlinus
    raphlinus committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    800fe1c View commit details
    Browse the repository at this point in the history

  4. Add test

    @raphlinus
    raphlinus committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    49fdad4 View commit details
    Browse the repository at this point in the history

  5. Doc update, per review

    @raphlinus
    raphlinus committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    bb47a0e View commit details
    Browse the repository at this point in the history