Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error on Mac when spin_no_std is enabled by dependents of lazy_static. (#2211) #2214

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Fix build error on Mac when spin_no_std is enabled by dependents of lazy_static. (#2211) #2214

merged 2 commits into from
Jul 2, 2022

Conversation

Steve-xmh
Copy link
Contributor

Fix build error on Mac when spin_no_std is enabled by dependents of lazy_static. (#2211)

@xStrom xStrom added bug does not behave the way it is supposed to S-blocked waits for another PR or dependency labels Jul 1, 2022
@xStrom
Copy link
Member

xStrom commented Jul 1, 2022

Thanks! We may end up going with this solution, or we may switch out lazy_static for once_cell as briefly discussed in #2211. I will look into this myself soon.

@Steve-xmh
Copy link
Contributor Author

Thanks! We may end up going with this solution, or we may switch out lazy_static for once_cell as briefly discussed in #2211. I will look into this myself soon.

That's ok, take your own time!

Anyway, switch to once_cell can be a good choice too. But we can merge it first if just need to temporarily fix this problem.

@xStrom
Copy link
Member

xStrom commented Jul 1, 2022

I think clippy will fail, as I'm still working on that PR myself. I'll run the tests to see.

@xStrom
Copy link
Member

xStrom commented Jul 1, 2022

Okay, master now has clippy issues solved thanks to #2215. You can rebase this on master and then the tests should succeed.

@Steve-xmh
Copy link
Contributor Author

Already merged.

@xStrom xStrom removed the S-blocked waits for another PR or dependency label Jul 2, 2022
xStrom
xStrom approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This does resolve the issue, so I'll approve this as the quick fix to have a working master.

Later we might switch out lazy_static completely, but that will be a separate PR.

@xStrom xStrom merged commit 6ed1ae3 into linebender:master Jul 2, 2022
@Steve-xmh Steve-xmh mentioned this pull request Jul 2, 2022
Closed
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
@Steve-xmh @xarvic
Fix build error on Mac when spin_no_std is enabled by dependents of l…
a9b65b5 
…azy_static. (linebender#2214)
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
@Steve-xmh @xarvic
Fix build error on Mac when spin_no_std is enabled by dependents of l…
26ad3b5 
…azy_static. (linebender#2214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
bug does not behave the way it is supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steve-xmh @xStrom