Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI and pin the Rust toolchain version. #2398

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Feb 23, 2024

This PR updates the CI to bring it more in sync with the current Linebender standard.

  • Various CI action versions were bumped
  • The Rust toolchain version is now pinned
  • Beta toolchain jobs were removed
  • Preparation for enabling merge queues

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels Feb 23, 2024
@xStrom
Copy link
Member Author

xStrom commented Feb 23, 2024

Unfortunately Rust 1.70 would no longer compile the workspace so I had to update to Rust 1.76. That meant also dealing with new Clippy lints. I addressed some and added a "temporary" ignore attribute to the difficult ones.

@@ -384,7 +384,6 @@ impl Manager {
if let Some(windata) = winhandle.data() {
windata.with_handler({
let windata = windata.clone();
let evt = evt;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@xStrom xStrom merged commit f45c892 into linebender:master Feb 23, 2024
12 checks passed
@xStrom xStrom deleted the updateci branch February 23, 2024 16:02
@xStrom xStrom removed the S-needs-review waits for review label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleans up code or docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants