Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerically approximate arc perimeter #381

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Numerically approximate arc perimeter #381

wants to merge 23 commits into from

Commits on Oct 29, 2024

  1. Impl ParamCurve, ParamCurveArclen for Arc 

    This uses an approximation of the arc length using beziers as the
analytic solution is quite involved.
    @waywardmonkeys @tomcur
    waywardmonkeys authored and tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ff7b25e View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
    @waywardmonkeys @DJMcNab @tomcur
    2 people authored and tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    25a7044 View commit details
    Browse the repository at this point in the history

  3. Numerically approximate ParamCurveArclen

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    212e91d View commit details
    Browse the repository at this point in the history

  4. Calculate for ellipse upper half, simplify arccos(a cos(x)/a) 

    Also add some more tests
    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c535a77 View commit details
    Browse the repository at this point in the history

  5. Correctly wrap around

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    12e841a View commit details
    Browse the repository at this point in the history

  6. Fix negative sweep angle normalization

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9eb7470 View commit details
    Browse the repository at this point in the history

  7. Add check comparing with bezier perimeter result

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    238176a View commit details
    Browse the repository at this point in the history

  8. Improve docs

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    29a8cd6 View commit details
    Browse the repository at this point in the history

  9. Improve readability

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    572853a View commit details
    Browse the repository at this point in the history

  10. Clippy

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4592b03 View commit details
    Browse the repository at this point in the history

  11. Improve docs

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c73d35e View commit details
    Browse the repository at this point in the history

  12. Probable performance improvements

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6d608df View commit details
    Browse the repository at this point in the history

  13. Fix wording

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fbad3e1 View commit details
    Browse the repository at this point in the history

  14. Division instead of powi

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9920d1f View commit details
    Browse the repository at this point in the history

  15. Start angle is modulo half turns

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    aba12cd View commit details
    Browse the repository at this point in the history

  16. trunc is faster than floor

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1a5c97c View commit details
    Browse the repository at this point in the history

  17. Reduce number of calls to integral calculation

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f54f4ab View commit details
    Browse the repository at this point in the history

  18. Provide rem_euclid in FloatFuncs

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    920728b View commit details
    Browse the repository at this point in the history

  19. clippy: group digits

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8953ba1 View commit details
    Browse the repository at this point in the history

  20. Fix erroneous agm_elliptic_perimeter if radius y > radius x 

    This doesn't (or doesn't easily?) occur for ellipses, as they instead
get a rotation when constructed with radius y > radius x.
    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    402dd3b View commit details
    Browse the repository at this point in the history

  21. Special-case complete elliptic perimeter

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8312bca View commit details
    Browse the repository at this point in the history

  22. Lift calculation to compile-time

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d0eb63d View commit details
    Browse the repository at this point in the history

  23. Don't calculate radii again

    @tomcur
    tomcur committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    886f6a4 View commit details
    Browse the repository at this point in the history