Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontique: Enable builds for iOS and other Apple targets. #47

Merged

Conversation

waywardmonkeys
Copy link
Contributor

Backend selection for iOS wasn't hooked up.

Also added support for tvOS as it is the same as iOS here.

@waywardmonkeys
Copy link
Contributor Author

Opened this as a draft for now for 2 reasons:

  1. It'll be in conflict with fontique: Remove unused deps. #46.
  2. We don't currently have iOS (or tvOS) CI and I don't think that should block this, but I wanted to call that out.
  3. There's a reasonable argument that we should use target_family = "apple" rather than any(target_os = "macos", target_os = "ios", target_os = "tvos") (and in the future, adding target_os = "visionos".

On the other hand, I should bring up points 2 and 3 in Zulip.

@waywardmonkeys
Copy link
Contributor Author

@waywardmonkeys waywardmonkeys marked this pull request as ready for review April 28, 2024 06:53
@waywardmonkeys
Copy link
Contributor Author

Going to adjust this one ...

@xorgy
Copy link
Member

xorgy commented Apr 29, 2024

@waywardmonkeys Out of curiosity, have you actually tried this on tvOS? (or whatever they are calling it by the time you reply)

@waywardmonkeys waywardmonkeys changed the title fontique: Enable builds for iOS and tvOS fontique: Enable builds for iOS and other Apple targets. Apr 29, 2024
This uses `target_vendor` despite the future deprecation as there
will be a replacement (likely using `target_family`) as the
deprecation nears.
@waywardmonkeys
Copy link
Contributor Author

This just uses CoreText which is the same on all Apple targets. I've built it for tvOS but haven't used it yet. (Need to get wgpu and other things updated.)

Not sure what the "or whatever they're calling it by the time you reply" is meant to mean or imply in any constructive sense.

@waywardmonkeys
Copy link
Contributor Author

This follows along with rust-lang/rust#124491

@xorgy
Copy link
Member

xorgy commented Apr 29, 2024

This just uses CoreText which is the same on all Apple targets. I've built it for tvOS but haven't used it yet. (Need to get wgpu and other things updated.)

Fair enough. A lot of other things differ, so I didn't assume that CoreText was the same on all the platforms.. as for trying it on tvOS/iOS, you should be able to run it without a renderer as far as I'm aware. That's how the original fontique examples (such as dump.rs) did it, and they'd give information about generic families, and it'd also tell you if there's anything exotic about the files on tvOS.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Apr 29, 2024
Merged via the queue into linebender:main with commit 0827eb6 Apr 29, 2024
19 checks passed
@waywardmonkeys waywardmonkeys deleted the enable-ios-tvos-builds branch April 29, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants