-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relicense under Apache-2.0 OR MIT
.
#844
Conversation
Can't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @golsby - are part of our move to MIT/Apache 2.0, the NOTICE
file would gain legal significance (due to the Apache 2.0 license), which wasn't desired. Because of this, we're removing that file.
(For context, see #697)
For cases where you require something to attribute, I'd suggest using both of the existing and new copyright notices:
Copyright (c) 2017 Yevhenii Reizner
Copyright (c) 2024 The Resvg authors
We can document this somewhere if you need that, although note that we cannot put that in a file named NOTICE
or with a name containing NOTICE
, due to the clause in the Apache 2.0 license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I'm not sure if we're completely read to merge this yet, but this seems right to me.
## Contribution | ||
|
||
Contributions are welcome by pull request. | ||
The [Rust code of conduct] applies. | ||
|
||
Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be licensed as above, without any additional terms or conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Xilem Core and Android Trace, I excluded this section from crate READMEs; a contribution is solely a repository level concern, so it isn't needed for clutter up the crate level README. Practically though, including it is also fine. Just providing this as food for thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have like 5 different variations of this across our repos. It's on my list to get standardized and then we can get back to it for all repos.
For now, I'd leave it as-is and get back to it with the result of the more detailed discussion.
keywords = ["svg"] | ||
license = "MPL-2.0" | ||
license.workspace = true | ||
edition = "2021" | ||
rust-version = "1.65.0" | ||
description = "An SVG simplification library." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also exclude "codegen"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that is automatic.
Regardless of whether
exclude
orinclude
is specified, the following files are always excluded:
@@ -3,7 +3,7 @@ AppName="resvg Explorer Extension" | |||
AppVersion="0.44.0" | |||
VersionInfoVersion="0.0.44.0" | |||
AppVerName="resvg Explorer Extension 0.44.0" | |||
AppPublisher="Yevhenii Reizner" | |||
AppPublisher="The Resvg Authors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I don't mind leaving this as-is. Perhaps use and the Resvg authors
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no different than all the other source files, which have been 99% written by Yevhenii Reizner. Even so, both here and elsewhere I went ahead with the more inclusive but concise standard of the Resvg Authors.
In conjunction with this change, I suggest making to make the project compatible with the REUSE Specification. REUSE was started by the Free Software Foundation Europe (FSFE) to provide a set of recommendations to make licensing your Free Software projects easy, comprehensive, unambiguous, and machine-readable.
|
Resvg is being relicensed under the
Apache-2.0 OR MIT
dual license. For for more background on that see #838.The practical steps to make that happen are as follows:
LICENSE-APACHE
andLICENSE-MIT
files in the repository root and in the root of all published packages.LICENSE-SUMMARY.txt
file for theexplorer-thumbnailer
installer. Thetxt
extension may be required.Cargo.toml
license info sourced from a single virtual workspaceCargo.toml
license
field.AUTHORS
file and referenced as the Resvg Authors.Cargo.toml
.cargo fmt
.explorer-thumbnailer
.