Resurrect pico_svg and use it to replace vello_svg in the examples. #518
Conversation
xorgy
force-pushed
the
bad-pico-svg-resurrection
branch
7 times, most recently
from
65bd3b9 to
3ce81b2
Compare
xorgy
force-pushed
the
bad-pico-svg-resurrection
branch
from
b4060f9 to
a656e57
Compare
There was a problem hiding this comment.
I've only skimmed the code, but it looks reasonable.
I don't think we can land this in a form which doesn't support all of the default downloads.
- Coat of arms of Poland gives "Unable to parse a number"
- More concerning, the SVG stroke test examples don't output any elements at all
The solution for 1 could be removing Coat of arms of Poland. But I don't think that's viable for issue 2.
|
@DJMcNab processing the examples with usvg CLI makes them all render, most of them correctly (except the ones that rely on stroke-linejoin and other things that are not decoded in pico_svg). With many of them, the issue is the use of CSS instead of attributes where it's not necessary. |
xorgy
force-pushed
the
bad-pico-svg-resurrection
branch
from
620820f to
3ab8d34
Compare
xorgy
force-pushed
the
bad-pico-svg-resurrection
branch
from
3ab8d34 to
bb8c29d
Compare
There was a problem hiding this comment.
@DJMcNab processing the examples with usvg CLI makes them all render, most of them correctly (except the ones that rely on stroke-linejoin and other things that are not decoded in pico_svg). With many of them, the issue is the use of CSS instead of attributes where it's not necessary.
I hope you can understand my thinking that's not a great end state. If the stroke features are out of scope, then I'd be happy for us to remove those examples.
I really don't think we should be downloading SVGs which don't work in the default state.
An alternative would be to host the converted SVGs ourselves (but not in this repo)
I ran into https://github.com/anishathalye/assets, which seems like a reasonable solution (of course, being careful about licenses). I think we should do something similar for the readme image, for example
So, approving conditional on removing the "broken" assets from the default_downloads, but with suggestions of alternative solutions which we could use.
|
My understanding was that we’d punt fancy SVG functionality to vello_svg and this repo would focus purely on tests that are directly relevant to vello dev, specifically tiger and Paris (and maybe Poland?). I don’t see why we need the download bits at all. |
No description provided.